🖌️ adopt dprint#471
Closed
KotlinIsland wants to merge 2 commits into
Closed
Conversation
Member
|
Thanks @KotlinIsland, LGTM! |
KotlinIsland
commented
Apr 7, 2025
Member
|
there's a merge conflict |
jorenham
reviewed
Apr 7, 2025
jorenham
left a comment
jorenham
left a comment
Member
There was a problem hiding this comment.
Thanks for this! I'm not sure I like the lack of configurability for the toml style, but it's probably better to be more like "black" this way.
This comment was marked as resolved.
This comment was marked as resolved.
Merged
Member
Since I can't force-push to your branch, I branched from your branch and continued your work in #471. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reviewers note: config/formatting are split across two commits
resolves #393